Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces enhancements and refactoring to the ARIMA-based time series generation and improves the organization of visualization utilities. The most significant changes include improved error handling and normalization options in the ARIMA simulator, the migration of the Shapiro-Wilk residual normality test to a dedicated visualization module, and updates to documentation and package imports for clarity and usability.
ARIMA Simulator Improvements:
revinparameter) to theARIMASimulator, allowing generated series to be normalized and later restored to original scale. [1] [2] [3] [4]ARIMASimulatorby checking for NaN values and effectively zero variance in input series, with clearer error messages. [1] [2]ValueErrorinstead of printing a warning, making failures more explicit.param_names,params,param_items).Visualization Refactoring:
plot_shapiro_wilkfunction froms2generator/utils/_tools.pytos2generator/utils/visualization.pyand updated imports and__all__accordingly. [1] [2] [3] [4] [5] [6] [7] [8] [9]Documentation Updates:
README.mdto highlight the new ARIMA-based time series generation method and clarify dependencies and installation instructions.Minor Cleanups: